[Mono-bugs] [Bug 599841] TabControl / TabPage Text and Image should be centered when SizeMode = Fixed

[bugzilla_noreply at novell.com]

http://bugzilla.novell.com/show_bug.cgi?id=599841

http://bugzilla.novell.com/show_bug.cgi?id=599841#c9


Thomas Goldstein <stifu at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357315|0                           |1
        is obsolete|                            |

--- Comment #9 from Thomas Goldstein <stifu at free.fr> 2010-04-28 21:35:27 UTC ---
Created an attachment (id=357563)
 --> (http://bugzilla.novell.com/attachment.cgi?id=357563)
Patch 3

The previous patch broke a little something: the tab texts were no longer moved
up by 2px when selecting a tab, due to the fact texts are now vertically
centered.

And thinking back about what I said in comment 5, it all makes more sense to me
now. I didn't understand how come the texts and images were shifted for the
active tab, but it's because the Rectangle that positions them is all-around
2px bigger when the tab is selected.
Also, I was bothered by the fact I had to manually shift the image for SizeMode
!= Fixed if the tab is selected, but this makes sense to me now as well: it's
the only case when a tab image isn't centered but aligned to the left, that's
why it must be shifted manually, because of the bigger rectangle mentioned
above which shifts the left rectangle bound.

Anyway, I now think this patch is good for review.
Let me know if I can help, I'd be happy to.

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.