[Mono-bugs] [Bug 508541] ComboBox has a useless vertical scrollbar

[bugzilla_noreply at novell.com]

http://bugzilla.novell.com/show_bug.cgi?id=508541

User stifu at free.fr added comment
http://bugzilla.novell.com/show_bug.cgi?id=508541#c1





--- Comment #1 from Thomas Goldstein <stifu at free.fr>  2009-05-30 14:17:16 MDT ---
Created an attachment (id=295366)
 --> (http://bugzilla.novell.com/attachment.cgi?id=295366)
Test case 2, adds a 2nd ComboBox w/ ComboBoxStyle.Simple

I had a look at this, and in the CalcListBoxArea, I think this part:

                if ((dropdown_style != ComboBoxStyle.Simple &&
owner.Items.Count <= owner.MaxDropDownItems)
                    || (dropdown_style == ComboBoxStyle.Simple &&
owner.Items.Count * owner.ItemHeight < height)) {

should be changed to:

                if ((owner.Items.Count <= owner.MaxDropDownItems)
                    || (owner.Items.Count * owner.ItemHeight <= height)) {

Because I can't see why the dropdown_style matters (and note the <= height
rather than < height, I think that's how it should be).

This change fixes this bug, but I'm not confident I'm not overlooking
something, so it'd be cool if someone could check.

Also, while checking if it didn't break anything regarding DropDownStyle =
ComboBoxStyle.Simple, I noticed this doesn't work right anyway (screenshot
coming)...

I'm attaching a new test case. It's the same as one above, but also adding a
ComboBox with DropDownStyle set to Simple, because all of that is related, all
in the CalcListBoxArea method.

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.