[Mono-bugs] [Bug 508523] ColorComboBox in FontDialog should show all 16 colors (no vertical scrollbar)

[bugzilla_noreply at novell.com]

http://bugzilla.novell.com/show_bug.cgi?id=508523

User stifu at free.fr added comment
http://bugzilla.novell.com/show_bug.cgi?id=508523#c1





--- Comment #1 from Thomas Goldstein <stifu at free.fr>  2009-05-30 10:47:15 MDT ---
Created an attachment (id=295358)
 --> (http://bugzilla.novell.com/attachment.cgi?id=295358)
Patch

The solution: increasing the DropDownHeight value of the ColorComboBox. Like
this:

                DropDownHeight = Items.Count * ItemHeight;

Since the DropDownHeight property of ComboBox is only available since .NET 2.0,
that leaves out .NET 1.1. Which is fine, actually, because that's what MS .NET
does, too. I double checked how FontDialog behaved in MS .NET 1.1, and there's
indeed a scrollbar in the ColorComboBox, unlike with MS .NET 2.0. So this is
most likely the right fix.

So, the patch I propose is:

#if NET_2_0
                DropDownHeight = Items.Count * ItemHeight;
#endif

Note: even with this patch, there is *still* a scrollbar, but it's useless, it
can't be used because all items are already visible. That's a separate bug in
ComboBox.

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.