[Mono-bugs] [Bug 377509] SRE: Argument name not emitted when attribute is applied to argument of setter

[bugzilla_noreply at novell.com]

http://bugzilla.novell.com/show_bug.cgi?id=377509

User rkumpera at novell.com added comment
http://bugzilla.novell.com/show_bug.cgi?id=377509#c3


Rodrigo Kumpera <rkumpera at novell.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rkumpera at novell.com
          Component|misc                        |C#
            Product|Mono: Runtime               |Mono: Compilers




--- Comment #3 from Rodrigo Kumpera <rkumpera at novell.com>  2009-05-26 09:58:53 MDT ---
This is a questionable bug on mcs and a big one on MS's SRE.

MS does a huge screw up when using MethodBuilder::DefineParameter because it
does add an extra row in the Param table for each call, which is the very
opposite of smart.

So, basically, under MS SRE mcs will generate broken assemblies. Under mono it
will generate assemblies without everything in.

I refuse to implement MS behavior on mono and the fix for mcs is quite trivial
actually.

The current behavior in mono is fine, and all that mcs has to do is to pass the
name of the damn parameter.

Something like:

--- a/mcs/parameter.cs
+++ b/mcs/parameter.cs
@@ -115,7 +115,7 @@ namespace Mono.CSharp {
                public ImplicitParameter (MethodBuilder mb):
                        base (null)
                {
-                       builder = mb.DefineParameter (1,
ParameterAttributes.None, "");                 
+                       builder = mb.DefineParameter (1,
ParameterAttributes.None, "value");            

                }

                public override AttributeTargets AttributeTargets {

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.