[Mono-bugs] [Bug 462016] make check for pinvoke2.exe fails for PowerPC

bugzilla_noreply at novell.com bugzilla_noreply at novell.com
Fri Jan 2 12:21:19 EST 2009


https://bugzilla.novell.com/show_bug.cgi?id=462016

User munroesj at us.ibm.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=462016#c13





--- Comment #13 from Steven Munroe <munroesj at us.ibm.com>  2009-01-02 10:21:18 MST ---
Applied this patch:

iff -urN mono-2.2/mono/mini/mini.c mono-2.2-patched/mono/mini/mini.c
--- mono-2.2/mono/mini/mini.c   2008-12-19 14:11:11.000000000 -0600
+++ mono-2.2-patched/mono/mini/mini.c   2008-12-30 12:12:54.000000000 -0600
@@ -10100,7 +10100,7 @@
                /* inst->backend.is_pinvoke indicates native sized value types,
this is used by the
                * pinvoke wrappers when they call functions returning
structures */
                if (inst->backend.is_pinvoke && MONO_TYPE_ISSTRUCT
(inst->inst_vtype) && inst->inst_vtype->type != MONO_TYPE_TYPEDBYREF)
-                       size = mono_class_native_size
(inst->inst_vtype->data.klass, &align);
+                       size = mono_class_native_size
(mono_class_from_mono_type (inst->inst_vtype), &align);
                else {
                        int ialign;


And the pinvoke2.exe test ran without error (with/without :MONO_GENERIC_SHARING
none):

mono/tests> MONO_PATH="../../../mcs/class/lib/net_2_0"
MONO_SHARED_DIR="/home/sjmunroe/src/mono-ppc/mono-svn/mono/runtime"
./mini/mono pinvoke2.exe
Regression tests: 71 ran, 0 failed in Tests

/mono/tests> MONO_GENERIC_SHARING="none"
MONO_PATH="../../../mcs/class/lib/net_2_0"
MONO_SHARED_DIR="/home/sjmunroe/src/mono-ppc/mono-svn/mono/runtime"
./mini/mono pinvoke2.exe
Regression tests: 71 ran, 0 failed in Tests

Still no clear if this is the final fix or we just got lucky with the data.


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the mono-bugs mailing list