[Mono-bugs] [Bug 429926] [Patch] OutputCache doesn't work

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=429926

User mhabersack at novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=429926#c4





--- Comment #4 from Marek Habersack <mhabersack at novell.com>  2008-09-25 09:55:41 MDT ---
(In reply to comment #3 from Juraj Skripsky)
> Marek, I'm not sure if my patch is really the right fix.
Well, it's not incorrect.

> In my opinion, both the CachedRawResponse items as well as the CachedVaryBy
> items should be stored in InternalCache. Otherwise we're polluting the user's
> cache with items having Request.FilePath as key!
Yes, that would be the ideal course of action. This was the primary goal when I
added the InternalCache.

> 
> Why is the line "internalCache.DependencyCache = cache;" in HttpRuntime.cs
I have no idea, I didn't add the code - but looking at it, using cache for
internalCache's dependency cache is indeed wrong. It should probably be an
entirely separate Cache instance. This cache is set on dependencies using
SetCache (see Cache.cs:160), which is why you see HasChanged in Dependency
using the "normal" cache.

> needed? This seems wrong. It implies that items in the internal cache can only
> depend on items in the user cache.
No, I don't think it implies that. DependencyCache seems to be just a separate
storage area for the depeendencies to use.

> I would much prefer to solve this issue first and then make OutputCache use
> InternalCache for all items. What do you think?
Let's try setting DependencyCache to 'new Cache ()' in HttpRuntime and use
InternalCache in OutputCacheModule for everything - please check if your
scenario works with such changes and, if yes, commit. Thanks!


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.