[Mono-bugs] [Bug 359181] [PATCH] FileSystemWatcher: OldName and Name swapped on rename

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=359181

User juraj at hotfeet.ch added comment
https://bugzilla.novell.com/show_bug.cgi?id=359181#c8


Juraj Skripsky <juraj at hotfeet.ch> changed:

           What    |Removed                                         |Added
----------------------------------------------------------------------------
             Status|RESOLVED                                        |REOPENED
         Resolution|FIXED                                           |




--- Comment #8 from Juraj Skripsky <juraj at hotfeet.ch>  2008-09-06 17:08:12 MDT ---
Rodrigo, I've just noticed that the patch you've applied (a) is slightly
different from the one I proposed (b):

(a) if (evt.Name != data.Directory && fsw.Pattern.IsMatch (evt.Name))

(b) if (evt.Name != data.Directory && !fsw.Pattern.IsMatch (evt.Name))

(see
http://anonsvn.mono-project.com/viewvc/trunk/mcs/class/System/System.IO/InotifyWatcher.cs?r1=97948&r2=106129&view=patch)


Was this change on purpose or by accident? In the former case, just reclose
this bug.

The if-condition should be the opposite of (evt.Name == data.Directory ||
fsw.Pattern.IsMatch (evt.Name)), and that would be (b) rather than (a)...


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.