[Mono-bugs] [Bug 420312] ToolStripCollectionEditor implementation

bugzilla_noreply at novell.com bugzilla_noreply at novell.com
Mon Sep 1 11:39:05 EDT 2008


User contact at i-nz.net added comment

--- Comment #1 from Ivan Zlatev <contact at i-nz.net>  2008-09-01 09:39:05 MDT ---
The NewItemTypes lazy initialization change is fine. 

For CreateNewItemTypes I think the best approach would be to hardcore a
predefined set of item types for each of the strips (menu, toolbar, etc) as
static array of types. Then use the Context to determine which list to use.

In addition we could use reflection to scan all loaded assemblies for all
public custom types subclasses of ToolStripItem, which are not part of our
hardcoded list to detect the custom ToolStripItems. Here we could check for
ToolStripItemDesignerAvailabilityAttribute on each of those to determine where
we can use them. Also note that it would be better if you use
TypeDescriptor.GetAttributes instead of Type.GetCustomAttributes

Then merge those 2 lists.

What do you think?

Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the mono-bugs mailing list