[Mono-bugs] [Bug 440220] [PATCH] Multiple faults in ProgressBar: ForeColor, negative Step, missing/wrong exceptions

bugzilla_noreply at novell.com bugzilla_noreply at novell.com
Thu Oct 30 11:01:16 EDT 2008


User andyhume32 at yahoo.co.uk added comment

Andy Hume <andyhume32 at yahoo.co.uk> changed:

           What    |Removed                                         |Added
            Summary|Multiple faults in ProgressBar: ForeColor,      |[PATCH] Multiple faults in ProgressBar:
                   |negative Step, missing/wrong exceptions         |ForeColor, negative Step, missing/wrong
                   |                                                |exceptions

--- Comment #3 from Andy Hume <andyhume32 at yahoo.co.uk>  2008-10-30 09:01:15 MDT ---
Attached patch fixes 1, 2, 3, 4, 5, 7, 8.  I haven't looked at the bad
calculation of #6, Marquee speed.

The changes to ProgressBar.cs should be uncontroversial.

The changes to Theme**.cs include possibly more than necessary.  Firstly
removing progressbarblock_color for #1 is simple.  Fix to #7 actually only
needs however:
+  block_width = Math.Max (block_width, 0); // block_width is used to break out
the loop below, it must be +ve!

The root cause is that ProgressBar.UpdateAreas doesn't ensure non-negative,
would that affect anything else?

Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the mono-bugs mailing list