[Mono-bugs] [Bug 318894] Minor: implement signal chaining for embedders.

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=318894

User lupus at novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=318894#c4


Paolo Molaro <lupus at novell.com> changed:

           What    |Removed                                         |Added
----------------------------------------------------------------------------
                 CC|                                                |lupus at novell.com




--- Comment #4 from Paolo Molaro <lupus at novell.com>  2008-10-09 08:46:09 MDT ---
There are a number of issues with the changes. first of all it doesn't follow
the mono coding style.
Then I'm pretty sure this would break where sigaction is not available: if you
didn't test that case, just leave it alone.
mono_chain_signal_handler () passes made up values to the handler, which is
incorrect.
In many of the cases, the mono_is_executing_managed () check doesn't make sense
as it doesn't matter if the signal is received while executing managed code or
not.
Then there is the issue of signal masks: they are completely ignored, so the
users will get the wrong behaviour.
Also, this new behaviour needs to happen only if it's explicitly enabled.


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.