[Mono-bugs] [Bug 429153] ListView: WndProc Mouse Events

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=429153

User calberto.cortez at gmail.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=429153#c6





--- Comment #6 from Carlos Alberto Cortez <calberto.cortez at gmail.com>  2008-10-08 17:58:44 MDT ---
Fair enough, the approach is correct. However, in order to commit your patch
asap, you need to take into account:

a) Read the coding guidelines. You are breaking the style in a lot of places.
b) From ItemControl.WndProc call directly ListView.WndProc instead of creating
a new useless method.
c) Don't change the name of the methods in ItemControl (like SetLastClicked for
ItemsMouseDown).
d) Don't let lines as comments (like, // TranslateEtc () ), if they are not
needed.
e) Why aren't you calling the base method for OnDoubleClick method?

You need to be specially careful of a) since that's why it can take more time
to read your patch, since there are so many changes that are not important, yet
they appear in the patch.

Also, new members need to have the proper style and indentation as well.


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.