[Mono-bugs] [Bug 431622] aspx files with + in their filenames causes invalid code

bugzilla_noreply at novell.com bugzilla_noreply at novell.com
Fri Oct 3 02:27:45 EDT 2008


User mhabersack at novell.com added comment

--- Comment #7 from Marek Habersack <mhabersack at novell.com>  2008-10-03 00:27:44 MDT ---
In general I have nothing against committing the patch, but in reality it's not
the right solution (like the code which deals with the issue already in
TemplateParser). The reason for this is that various languages allow various
characters in identifier names and we cannot embrace them all like that. What
we should probably do is try to make sure that each identifier generated by
asp.net is a language idependent one (using
CodeGenerator.IsValidLanguageIndependentIdentifier) and, if not, encode the
identifier to replace all the characters outside the Unicode classes allowed by
the above method as '_'. And this is what I'm probably going to implement right
now :)
Another thing we should do, but we don't (since the feature is not implemented
in Mono), is to call CodeGenerator.ValidateIdentifiers when the entire code
unit graph is constructed and bail out if it throws an exception.
Rolf, I will take the liberty not to apply the patch but I will develop the
solution I proposed above instead.

Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the mono-bugs mailing list