[Mono-bugs] [Bug 315250] Use frndint for Math.Round

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=315250

User rkumpera at novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=315250#c4


Rodrigo Kumpera <rkumpera at novell.com> changed:

           What    |Removed                                         |Added
----------------------------------------------------------------------------
                 CC|                                                |rkumpera at novell.com




--- Comment #4 from Rodrigo Kumpera <rkumpera at novell.com>  2008-11-12 06:40:43 MST ---
Hi Scott,

You should make your changes against trunk of the 2.2 branch as the JIT have
changed a lot.

You patch lacks regression tests to the mini test suite.


Besides that, your patch looks good except for this:

Index: mono/arch/x86/x86-codegen.h
===================================================================
--- mono/arch/x86/x86-codegen.h (revision 118562)
+++ mono/arch/x86/x86-codegen.h (working copy)
@@ -1659,6 +1659,7 @@
 #define x86_frndint(inst) do { *(inst)++ = (unsigned char)0xd9; *(inst)++ =
(unsigned char)0xfc; } while (0)
 #define x86_fsqrt(inst) do { *(inst)++ = (unsigned char)0xd9; *(inst)++ =
(unsigned char)0xfa; } while (0)
 #define x86_fptan(inst) do { *(inst)++ = (unsigned char)0xd9; *(inst)++ =
(unsigned char)0xf2; } while (0)
+#define x86_frndint(inst) do { *(inst)++ = (unsigned char)0xd9; *(inst)++ =
(unsigned char)0xfc; } while (0)


Notice that x86_frndint is already defined.


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.