[Mono-bugs] [Bug 386415] [PATCH] Implementation of mono_method_get_unmanaged_thunk

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=386415

User vargaz at gmail.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=386415#c3


Zoltan Varga <vargaz at gmail.com> changed:

           What    |Removed                                         |Added
----------------------------------------------------------------------------
                 CC|                                                |vargaz at gmail.com




--- Comment #3 from Zoltan Varga <vargaz at gmail.com>  2008-05-03 08:23:12 MST ---
Some comments about the patch:
- It should contain some asserts for the stuff it does not supports
(valuetypes),
  since users _will_ use try to use it for that despite the documentation.
- 
+       csig->params [param_count - 1] = mono_metadata_type_dup
(image->mempool,
+                &mono_defaults.exception_class->byval_arg);
  no need for the type_dup, &mono_defaults.exception_class->byval_arg is
enough.
- the tests look a bit ugly, but at least we now have some automated tests 
  for parts of the embedding api :)

Otherwise, the patch looks good. Thanks!


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.