[Mono-bugs] [Bug 396076] PropertyGrid: ignores set of Padding "All" value

bugzilla_noreply at novell.com bugzilla_noreply at novell.com
Thu Jun 19 21:15:59 EDT 2008


User contact at i-nz.net added comment

Ivan Zlatev <contact at i-nz.net> changed:

           What    |Removed                                         |Added
             Status|ASSIGNED                                        |RESOLVED
         Resolution|                                                |FIXED

--- Comment #8 from Ivan Zlatev <contact at i-nz.net>  2008-06-19 19:15:58 MDT ---
I have applied your patch in r106273 with the modifications as follows (list
written down while doing them, so probably not great):

   1. Coding Style - space before (
   2. Coding Style - Properties { on same line
   3. Coding Style - field naming - no m_ prefixes, etc
   4. Coding Style - align parameters list in method signatures to the ones on
the previous line.
   5. Coding Style - no {} for single line if-else
   6. Exception -> NotimplementedException
   7. ArgumentNullReferenceException parameter name -> match the string to the
param name
   8. Removed the commented out CWLs
   9. Do not compare exception's message and other details. This might break
running the tests on non-english locale as Atsushi Eno pointed out on the
mono-devel mailing list recently. Just fail if exception doesn't get thrown
  10. ConvertTo_InstanceDescriptor - dropped helper method and used only
AreEqual (it will compare all properties of the Padding as it ends up calling
Padding.Equals anyway) for the sake of simplicity
  11. No need to "internal" helper methods
  12. Drop some helper methods here and there and simplify here and there.
Tests should be simple and self contained units. Code duplication in tests is
fine imho.

Mono Project's code guidelines can be found here -

Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the mono-bugs mailing list