[Mono-bugs] [Bug 375987] System.Windows. Forms dependency on GTK makes code to crash if it uses ATK# and GTK_MODULES contains 'atk-bridge'

bugzilla_noreply at novell.com bugzilla_noreply at novell.com
Mon Jun 16 12:13:36 EDT 2008


User sanfordarmstrong at gmail.com added comment

--- Comment #13 from Sanford Armstrong <sanfordarmstrong at gmail.com>  2008-06-16 10:13:35 MDT ---
(In reply to comment #11 from Geoff Norton)
> Comments:
> 1.  Please try not to include whitespace changes.

Whoops, will fix those.

> 2.  Please follow the mono code guidelines

I guess you mean method call arguments not being aligned correctly?  Will fix. 
Didn't notice anything else.

> 3.  It appears you only guard against the crash in the .NET 2.0 case?  Why?  Is
> this intentional?  If so it needs to be documented.

Nothing new at all happens in the .NET 2.0 case, because UIA requires .NET 2.0.

> 4.  Introducing a global const string that is used only once seems kind of
> silly to me.

Alrighty, I'll make them local to the InitializeUIAutomation method.

> 5.  Please document what FormAdded and PreRun are supposed to be used for.  If
> they're UIA only maybe we should do #region UIA around the stuff? (jpobst?)

You mean document them in the code?  No problem.  FormAdded is just a way for
us to be notified of when a new form appears that needs a11y support, and
PreRun lets us run initialization code before Application.Run is finished being
called.  I suppose they could be useful to others, but I added them
specifically to meet our UIA needs.

I'll attach a new patch shortly.

Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the mono-bugs mailing list