[Mono-bugs] [Bug 375987] System.Windows. Forms dependency on GTK makes code to crash if it uses ATK# and GTK_MODULES contains 'atk-bridge'

bugzilla_noreply at novell.com bugzilla_noreply at novell.com
Mon Jun 16 11:59:54 EDT 2008


https://bugzilla.novell.com/show_bug.cgi?id=375987

User gnorton at novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=375987#c11





--- Comment #11 from Geoff Norton <gnorton at novell.com>  2008-06-16 09:59:54 MDT ---
Comments:

1.  Please try not to include whitespace changes.
2.  Please follow the mono code guidelines
3.  It appears you only guard against the crash in the .NET 2.0 case?  Why?  Is
this intentional?  If so it needs to be documented.
4.  Introducing a global const string that is used only once seems kind of
silly to me.
5.  Please document what FormAdded and PreRun are supposed to be used for.  If
they're UIA only maybe we should do #region UIA around the stuff? (jpobst?)


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the mono-bugs mailing list