[Mono-bugs] [Bug 398274] New: TableLayoutSettingsTypeConverter fails reading (known) bad data

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=398274


           Summary: TableLayoutSettingsTypeConverter fails reading (known)
                    bad data
           Product: Mono: Class Libraries
           Version: 1.9.0
          Platform: Other
        OS/Version: Other
            Status: ASSIGNED
          Severity: Normal
          Priority: P5 - None
         Component: Windows.Forms
        AssignedTo: jpobst at novell.com
        ReportedBy: andyhume32 at yahoo.co.uk
         QAContact: mono-bugs at lists.ximian.com
          Found By: ---


Created an attachment (id=220872)
 --> (https://bugzilla.novell.com/attachment.cgi?id=220872)
Test cases patch

Additional unit tests attached.  I'll leave the fix to you Jonathan. :-)

Two problems in TableLayoutSettingsTypeConverter (other keywords
TableLayoutSettings, TableLayoutPanel):

1. ConvertTo writes: "Columms"  !! two 'm's !!

2. MSFT (in the past?) generated bad content when the current culture had comma
as its decimal point character, e.g. writing:
  "Percent,25,5,Percent,75,5"
instead of:
  "Percent,25.5,Percent,75.5"

See
https://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=156278
(and 271059)
also one which notes the fix _didn't_ to fix the output:
https://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=324138
Also
http://www.microsoft.com/communities/newsgroups/en-us/default.aspx?dg=microsoft.public.dotnet.internationalization&tid=f11516e2-33da-4047-8e2f-205df4ab09e5&cat=en_US_3fcb35c8-ccb3-4554-bd55-8038c0ecc923&lang=en&cr=US&sloc=&p=1

Mono crashes on reading the odd content; MSFT (with SP1?) doesn't (I haven't
looked what objects it returns however).


I attach a patch containing additional tests to test such things.  Also
includes a tiny fix to the currently NotWorking test -- it just needed the XML
elements reordered to work (and uncover the "Columms" bug)!  Very simple tests
first!!

The ConvertFrom (i.e. input tests) don't check the result (yet? -- does Equals
work??), just that no exception occurs.  Testing of various "Control" elements
is missing too, etc etc.


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.