[Mono-bugs] [Bug 356552] New: System.Net.Sockets.SocketTest. SocketError fails on solaris x86

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=356552

User vargaz at gmail.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=356552#c73053

           Summary: System.Net.Sockets.SocketTest.SocketError fails on
                    solaris x86
           Product: Mono: Runtime
           Version: unspecified
          Platform: i586
        OS/Version: Solaris
            Status: NEW
          Severity: Minor
          Priority: P5 - None
         Component: io-layer
        AssignedTo: dick at novell.com
        ReportedBy: vargaz at gmail.com
         QAContact: mono-bugs at lists.ximian.com
          Found By: ---


The above class library test fails on solaris x86. The following patch
seems to fix it:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
Index: mono/mono/io-layer/sockets.c
===================================================================
--- mono/mono/io-layer/sockets.c        (revision 94009)
+++ mono/mono/io-layer/sockets.c        (working copy)
@@ -312,6 +312,18 @@
                                errnum = WSAEWOULDBLOCK; /* see bug #73053 */

                        WSASetLastError (errnum);
+
+                       /*
+                        * On solaris x86 getsockopt (SO_ERROR) is not set
after
+                        * connect () fails so we need to save this error.
+                        */
+                       ok = _wapi_lookup_handle (handle, WAPI_HANDLE_SOCKET,
+                                                 (gpointer *)&socket_handle);
+                       if (ok == FALSE) {
+                               g_warning ("%s: error looking up socket handle
%p", __func__, handle);
+                       } else {
+                               socket_handle->saved_error = errnum;
+                       }

                        return(SOCKET_ERROR);
                }
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.