[Mono-bugs] [Bug 359098] [PATCH] AutoScale fixes for both 2.0 and 1.0 style

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=359098

User jpobst at novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=359098#c3


Jonathan Pobst <jpobst at novell.com> changed:

           What    |Removed                                         |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                                        |RESOLVED
         Resolution|                                                |FIXED




--- Comment #3 from Jonathan Pobst <jpobst at novell.com>  2008-02-19 08:46:17 MST ---
Committed in r95295.  Thanks for the report, patch, and tests!

2008-02-08  Jonathan Pobst  <monkey at jpobst.com>

        Commit patch from James Purcell for better AutoScale implementation:

        * ScaleControl should call GetScaledBounds with the control's total
size rather
        than client size.  GetScaledBounds should handle ignoring the borders
in its
        calculations.  Cleaned up ScaleControl/GetScaledBounds overrides in
controls
        (for the most part they just call the base code now since that is
fixed).
        * Added ScaleChildrenInternal to allow controls to disable scaling of
children
        without having to override ScaleChildren (since none of .NET's controls
do). 
        This is required for most controls in Mono that have scrollbars to
prevent the
        scrollbars from being moved/resized.
        * Nested ContainerControls can have a different scale mode than their
parent. 
        This is briefly mentioned in MSDN but is buggy in MS.NET (the runtime
and
        designer produce different results both of which look incorrect).
        * Default AutoScaleMode for ContainerControl should be Inherit.
        * Simplified workaround for ComboBox scaling issue.
        * 1.0 style auto-scaling now uses its own methods instead of sharing
2.0's. 
        1.0 style auto scaling should scale the whole control's size instead of
        ignoring the borders (except for Form) and the rounding is done
differently to
        preserve control alignment.
        * ApplyAutoScaling (used for 1.0 style) should use the rounded result
of
        GetAutoScaleSize.
        * Cleaned up fix for "Bug 355703 - Setting AutoScale = true doesn't
stick".
        * CurrentAutoScaleDimensions should round the estimated character width
instead
        of truncating.
        * ListBox's GetScaledBounds should always use the height it was set to
instead
        of the height that was passed in.  This prevents rounding errors from
        accumulating quickly with IntegralHeight.
        [Bug #359098]

2008-02-08  Jonathan Pobst  <monkey at jpobst.com>

        * FormTest.cs: Commit tests from James Purcell for his new
        AutoScale implementation.  [Bug #359098]


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.