[Mono-bugs] [Bug 410608] NullReferenceException saving icon

bugzilla_noreply at novell.com bugzilla_noreply at novell.com
Wed Aug 6 17:23:45 EDT 2008


User gert.driesen at pandora.be added comment

--- Comment #4 from Gert Driesen <gert.driesen at pandora.be>  2008-08-06 15:23:44 MDT ---
Created an attachment (id=232132)
 --> (https://bugzilla.novell.com/attachment.cgi?id=232132)
Fix and unit test

This patch fixes the issue, and add a unit test.  Should I merge the test with
the existing Save test?

The icon that I added was taken from bug #323511. If the patch is approved,
I'll add this as a comment to that bug (to avoid adding this icon twice).

Should we first add the IconDirEntry instances to an arraylist, and copy that
to an IconDirEntry array? Right now, we allocate extra slots in the array for
256x256 icons (since we skip these). My patch does not touch this.

I also think we are using the wrong id when we check the size, in case a
256x256 icon was skipped before. We apparently use i instead of p.  See line
686. Let me know if you want a separate bug report for this.

Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the mono-bugs mailing list