[Mono-bugs] [Bug 81663][Wis] Changed - [PATCH] Performance: Delegate optimization, DLR and IronPython

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by lupus at ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=81663

--- shadow/81663	2007-09-02 06:05:52.000000000 -0400
+++ shadow/81663.tmp.6076	2007-09-06 11:10:31.000000000 -0400
@@ -314,6 +314,17 @@
 Achitecture Delegate Impl with InterlockedCompareExchange
 
 
 ------- Additional Comments From vargaz at gmail.com  2007-09-02 06:05 -------
 This looks ok to check in.
 
+
+------- Additional Comments From lupus at ximian.com  2007-09-06 11:10 -------
+There are a few issues:
+*) the has_target case doesn't need a cache based on the number of
+arguments: there is going to be just one version regardless of the
+arguments.
+*) delegate_invoke_impl_with_target_hash needs to be removed also from
+domain.c and the header files
+*) you need a space before any open [
+*) even if the possible leak is minimal, it's so easy to avoid it
+using a lock that it's best to handle it properly