[Mono-bugs] [Bug 325397] DbTransaction: Rollback is wrongly invoked in Dispose (bool)

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=325397#c4


Gert Driesen <gert.driesen at pandora.be> changed:

           What    |Removed                                         |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                                        |ASSIGNED
      Info Provider|dobos at complex.elte.hu                           |
            Summary|Transaction.Commit occures in                   |DbTransaction: Rollback is wrongly invoked in
                   |Transaction.Dispose                             |Dispose (bool)




--- Comment #4 from Gert Driesen <gert.driesen at pandora.be>  2007-10-16 12:41:40 MST ---
I've added a DbTransactionTest.cs class containing a unit test that shows that
we're currently invoking RollBack in Dispose (bool), while MS does not appear
to do anything in Dispose (bool).

MS appears to leave it up to the deriving classes to override Dispose (bool)
and perform a rollback (when necessary?). This makes sense of course.

I've verified whether our implementation of DbTransaction are behaving
correctly, and from a quick look it seems that all except OleDbTransaction are
performing a rollback in Dispose (bool).

Before removing the call to Rollback we should:
* add standalone tests that verify the correct behavior on Dispose.
=> I'll add standalone tests to my test repository 

* fix and test OleDbTransaction

Does this sound like a plan?


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.