[Mono-bugs] [Bug 324135] eglib does not build on Mac OS X

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=324135#c9





--- Comment #9 from Andreas Färber <andreas.faerber at web.de>  2007-11-06 11:30:26 MST ---
Is there a special reason you omitted my include path fix in Makefile.am? This
is needed to support VPATH:
-test_eglib_CFLAGS = -Wall -Werror -D_FORTIFY_SOURCE=2 -I$(srcdir)/../src
-DDRIVER_NAME=\"EGlib\"
+test_eglib_CFLAGS = -Wall -Werror -D_FORTIFY_SOURCE=2 -I$(srcdir)/../src
-I../src -DDRIVER_NAME=\"EGlib\"
Generated files live in the build directory, not source directory.

Also, could you please take a look there how we could remove the dependency on
an external glib or running the tests alltogether? That's a problem for
OSX/ppc64 and for cross-compiling in general.

In gpath.c there is an apparent typo:
-#ifdef HAVE_GETPWNENT_R
+#ifdef HAVE_GETPWENT_R
and I had spotted some Mono coding style violations (a number of missing spaces
before {).

In g_strndup (gstr.c) g_malloc should be used instead of malloc and '\0' should
be assigned (warning?), also gchar should be used instead of char and there's a
space missing. (remaining diff between Jonathan's and mine)

In glib.h, is there some reason not to apply this?
-#define ABS(a)         ((a) > 0 ? (a) : -(a))
+#define ABS(a)         ((a) >= 0 ? (a) : -(a))
It avoids an unnecessary negation when a==0.


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.