[Mono-bugs] [Bug 339122] New: function mono_type_get_modifiers lacks implementation

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=339122

           Summary: function mono_type_get_modifiers lacks implementation
           Product: Mono: Runtime
           Version: 1.2
          Platform: Other
        OS/Version: All
            Status: NEW
          Keywords: patch
          Severity: Minor
          Priority: P5 - None
         Component: debug
        AssignedTo: martin at novell.com
        ReportedBy: piotr.lesnicki at st.com
         QAContact: mono-bugs at ximian.com
          Found By: Development


Created an attachment (id=182046)
 --> (https://bugzilla.novell.com/attachment.cgi?id=182046)
patch for [solution2] : with no signature change but internal struct change

Function 'mono_type_get_modifiers' in metadata/metadata.c has no implementation
yet. It's the API function to get "modopts" which can also be accessed in a
less clean way directly from the MonoCustomMod structure. 

Implementing this function requires either:
 - to change its signature and add a (MonoImage*) argument [solution1]
 - to add a (MonoClass*) field to MonoCustomMod structure [solution2]
because this function returns a MonoClass* and at some point this MonoClass has
to be resolved from the token information.

Personnally I think [solution2] is more consistant as it keeps the metadata API
intact and moreover it is more conveniant in a MonoCustomMod to have the higher
level information (MonoClass more than a token). The token field could even be
removed then imho.

I join thereafter patches for implementations of both solutions.

Piotr


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.