[Mono-bugs] [Bug 81520][Wis] Changed - [PATCH] Mono does not build with latest eglib on Mac OS X

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by andreas.faerber at web.de.

http://bugzilla.ximian.com/show_bug.cgi?id=81520

--- shadow/81520	2007-05-03 10:52:33.000000000 -0400
+++ shadow/81520.tmp.19987	2007-05-03 15:12:42.000000000 -0400
@@ -77,6 +77,17 @@
 ------- Additional Comments From lupus at ximian.com  2007-05-03 10:52 -------
 g_printerr has the same issue and it is not handled.
 Proper test cases should be added to the test suite for each of these
 macros before changes are committed.
 It is also very likely that some compilers require the previous
 version of the code, so add a configure.in check and use it in the header.
+
+------- Additional Comments From andreas.faerber at web.de  2007-05-03 15:12 -------
+Paolo, did you see that on OS X? I did not notice, and as mentioned in http://
+bugzilla.ximian.com/show_bug.cgi?id=81456 for me eglib/test/ does not work at all as is. 
+Could you please comment on how to fix it in an SVN-acceptable manner?
+
+Where should the macro tests be added and what exactly should be checked with autoconf? 
+(or do you know, Jonathan?)
+And throwing an error as part of the test suite is probably not the best of all ideas (assuming 
+it would lead make to abort), while a statement such as if (0) g_error(""); might be optimized 
+away?