[Mono-bugs] [Bug 81181][Nor] New - typo in free_cached_pattern() in font.c

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by choe.hwanjin at gmail.com.

http://bugzilla.ximian.com/show_bug.cgi?id=81181

--- shadow/81181	2007-03-19 03:30:05.000000000 -0500
+++ shadow/81181.tmp.17777	2007-03-19 03:30:05.000000000 -0500
@@ -0,0 +1,53 @@
+Bug#: 81181
+Product: Mono: Class Libraries
+Version: 1.0
+OS: 
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: 
+Priority: Normal
+Component: libgdiplus
+AssignedTo: mono-bugs at ximian.com                            
+ReportedBy: choe.hwanjin at gmail.com               
+QAContact: mono-bugs at ximian.com
+TargetMilestone: ---
+URL: 
+Cc: 
+Summary: typo in free_cached_pattern() in font.c
+
+Please fill in this template when reporting a bug, unless you know what you
+are doing.
+Description of Problem:
+
+There is a typo in free_cached_pattern() in font.c.
+This function will delete the allocated GHashTable item. So it should
+delete the key and the value. But it deletes value twice.
+
+
+Steps to reproduce the problem:
+1. 
+2. 
+3. 
+
+Actual Results:
+double free.
+
+Expected Results:
+
+
+How often does this happen? 
+Always
+
+
+Additional Information:
+
+static
+gboolean free_cached_pattern (gpointer key, gpointer value, gpointer user)
+{
+        g_free (value); /* -> this should be g_free(key); */
+        FcPatternDestroy ((FcPattern*) value);
+        return TRUE;
+}
+
+I made a patch for this problem.