[Mono-bugs] [Bug 81095][Nor] Changed - [Patch] ToolboxItem.GetType must not be dependant on ITypeResolutionService

bugzilla-daemon at bugzilla.ximian.com bugzilla-daemon at bugzilla.ximian.com
Wed Mar 14 12:00:07 EDT 2007

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by sebastien at ximian.com.


--- shadow/81095	2007-03-10 16:07:03.000000000 -0500
+++ shadow/81095.tmp.28170	2007-03-14 11:00:07.000000000 -0500
@@ -1,12 +1,12 @@
 Bug#: 81095
 Product: Mono: Class Libraries
 Version: 1.2
 OS: unknown
 OS Details: 
-Status: NEW   
+Status: NEEDINFO   
 Severity: Unknown
 Priority: Normal
 Component: Sys.Drawing.
 AssignedTo: mono-bugs at ximian.com                            
 ReportedBy: contact at i-nz.net               
@@ -26,6 +26,43 @@
 Created an attachment (id=18866)
 Patch + ChangeLog entry
 ------- Additional Comments From gert.driesen at pandora.be  2007-03-10 16:07 -------
 Can you also submit unit tests for this change ?
+------- Additional Comments From sebastien at ximian.com  2007-03-14 11:00 -------
+I guess that's not something easily testable from nunit, right ?
+The patch has a few minor issues to fix before being committed.
+* Your ChangeLog entry must be done at the same directory level as the
+patch (not at the assembly level);
+* The first two lines of the patch indicates that the file has mixed
+line endings. This is better fixed in a separate commit (r74256).
+* You fixed some code style issue, but not all of them. E.g. there's
+still a missing ' ' after typeof. Either keep the original line and
+fix the style completely.
++			ITypeResolutionService typeRes = host.GetService
+(typeof(ITypeResolutionService)) as ITypeResolutionService;
+* The recent guidelines (old ones were different IIRC) requires a
+single line for the else
++			}
++			else {
+* Please use the Assembly.Load (assemblyName)
++				Assembly assembly = Assembly.Load (assemblyName.FullName);
+Once fixed this is ok to commit (of course if you can think of some
+additional tests this would be better in the long run).
+Do you have SVN write access ? 
+If not attach the updated patch and I'll commit it.

More information about the mono-bugs mailing list