[Mono-bugs] [Bug 80604][Nor] Changed - Form.Visible should return true during OnLoad

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by toshok at ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=80604

--- shadow/80604	2007-03-12 16:52:27.000000000 -0500
+++ shadow/80604.tmp.11752	2007-03-12 16:55:51.000000000 -0500
@@ -97,6 +97,19 @@
 before calling XplatUI.SetVisible.  I just committed a test -
 ControlTest.CreateControlVisibleTest - which confirms this.  Actually,
 by the time CreateControl is called, the control should already be
 visible (i.e. is_visible will be true.)
 
 I'll dig deeper.
+
+------- Additional Comments From toshok at ximian.com  2007-03-12 16:55 -------
+so, as rolf told me in irc, it turns out this is due to the faulty way
+we were handling WM_QUIT and XplatUI.PostQuitMessage.  the second
+Show() never succeeded because our WaitForHandMessage returns
+immediately (and the form isn't shown).
+
+the fix is to actually fix the way we handle PostQuitMessage.  I have
+a patch for it, and am testing it now.
+
+One other thing we should do is rewrite Control.SetVisibleCore so that
+we don't end up calling XplatUI.SetVisible twice when we create the
+control and set Visible to true.