[Mono-bugs] [Bug 81859][Nor] New - [PATCH] GdipReversePath should reverse path->types too

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by doc.formatique at gmail.com.

http://bugzilla.ximian.com/show_bug.cgi?id=81859

--- shadow/81859	2007-06-11 17:17:32.000000000 -0400
+++ shadow/81859.tmp.26548	2007-06-11 17:17:32.000000000 -0400
@@ -0,0 +1,49 @@
+Bug#: 81859
+Product: Mono: Class Libraries
+Version: unspecified
+OS: All
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: 
+Priority: Normal
+Component: libgdiplus
+AssignedTo: mono-bugs at ximian.com                            
+ReportedBy: doc.formatique at gmail.com               
+QAContact: mono-bugs at ximian.com
+TargetMilestone: ---
+URL: 
+Cc: 
+Summary: [PATCH] GdipReversePath should reverse path->types too
+
+Description of Problem:
+
+GdipReversePath reverses the path's points, not the points' type.
+
+Steps to reproduce the problem:
+
+Testcase attached. Works on Windows.
+
+Actual Results:
+
+Abort
+
+Expected Results:
+
+Success
+
+Additional informations:
+
+Attached patch builds a new path->types array, walking the old one
+subpath-per-subpath building a new one, then reversing it.
+
+Building the new array would be trivial (swap the CloseSubpath and DashMode
+flags), but for the possible PathMarker. AFAIU, markers are meant to be
+placed between pairs of points (p1, p2): so we must:
+
+* swap them from the old p1 to the new one
+* if one apears on the last point of a subpath, put it at the end of its
+predecessor.
+
+The tests I included may not cover all the code paths: I did more on
+Windows then tried to get only the 'interesting' ones.