[Mono-bugs] [Bug 81845][Nor] New - Using with C++ compilers / -Werror

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by doc.formatique at gmail.com.

http://bugzilla.ximian.com/show_bug.cgi?id=81845

--- shadow/81845	2007-06-10 06:55:39.000000000 -0400
+++ shadow/81845.tmp.12385	2007-06-10 06:55:39.000000000 -0400
@@ -0,0 +1,34 @@
+Bug#: 81845
+Product: Mono: Class Libraries
+Version: unspecified
+OS: All
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: 
+Priority: Normal
+Component: libgdiplus
+AssignedTo: mono-bugs at ximian.com                            
+ReportedBy: doc.formatique at gmail.com               
+QAContact: mono-bugs at ximian.com
+TargetMilestone: ---
+URL: 
+Cc: 
+Summary: Using with C++ compilers / -Werror
+
+GdiPlusFlat.h has a few problems when using in a C++ program:
+
+* it lacks extern "C"
+
+* in the BitmapData struct,
+          PixelFormat     PixelFormat;
+  is not valid C++ (compilers are not required to error on it, but G++ does)
+
+* "general.h" and "image.h" are not included (perhaps others)
+
+To include image.h, we must first remove its #include "gdiplus-private.h",
+which propagates in a few other files.
+
+The attached patch fix these, and also a few problems in tests/testbits.c
+and tests/testgdi.c which prevented them to compile with -Wall -Werror. The
+tests still don't pass on my x86-64 PC, though.