[Mono-bugs] [Bug 81771][Wis] Changed - Null object reference after ListControl.DataSource is set to null

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by albright at wesay.org.

http://bugzilla.ximian.com/show_bug.cgi?id=81771

--- shadow/81771	2007-06-04 18:39:22.000000000 -0400
+++ shadow/81771.tmp.13044	2007-07-11 23:51:19.000000000 -0400
@@ -1,13 +1,13 @@
 Bug#: 81771
 Product: Mono: Class Libraries
 Version: 1.2
 OS: unknown
 OS Details: 
-Status: RESOLVED   
-Resolution: FIXED
+Status: REOPENED   
+Resolution: 
 Severity: Unknown
 Priority: Wishlist
 Component: Windows.Forms
 AssignedTo: calberto.cortez at gmail.com                            
 ReportedBy: albright at wesay.org               
 QAContact: mono-bugs at ximian.com
@@ -46,6 +46,23 @@
 This should be fixed in SVN.
 
 Could you confirm it?
 
 ------- Additional Comments From unserkonig at gmail.com  2007-06-04 18:39 -------
 Assuming the bug as fixed.
+
+------- Additional Comments From albright at wesay.org  2007-07-11 23:51 -------
+Now if you assign a list then assign a different list then assign null
+and make a change to the first list it will crash.
+
+I think the code (ListControl.cs:ConnectToDataSource) should be:
+
+if (data_manager != null) { // Disconnect handlers from previous manager
+  data_manager.PositionChanged -= new EventHandler (OnPositionChanged);
+  data_manager.ItemChanged -= new ItemChangedEventHandler (OnItemChanged);
+} 
+
+if (data_source == null) {
+	data_manager = null;
+	return;
+}
+