[Mono-bugs] [Bug 79279][Nor] Changed - System.IO.Ports.SerialPort ReadLine behaviour differs from MS .NET implementation

bugzilla-daemon at bugzilla.ximian.com bugzilla-daemon at bugzilla.ximian.com
Thu Jan 11 23:24:45 EST 2007


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by alp at atoker.com.

http://bugzilla.ximian.com/show_bug.cgi?id=79279

--- shadow/79279	2006-09-05 09:06:54.000000000 -0400
+++ shadow/79279.tmp.7537	2007-01-11 23:24:45.000000000 -0500
@@ -35,6 +35,13 @@
 				int n = stream.Read (buff, 0, 1);
 				if (n == -1 || buff [0] == new_line[0])
 					break;
 				bytes_read.Add (buff [0]);
 			} 
 			return new String (encoding.GetChars (bytes_read.ToArray ()));
+
+------- Additional Comments From alp at atoker.com  2007-01-11 23:24 -------
+I remember reviewing this patch some time ago but the comment did not
+get added. I think the patch needs at least a small state machine for
+CR/LF -- there are many examples of this in other parts of the class
+libraries to borrow from. If you can do this, the patch will be good
+to commit and should be done.


More information about the mono-bugs mailing list