[Mono-bugs] [Bug 80495][Nor] Changed - Button with DialogResult set to OK should work even if it's not directly on a form

bugzilla-daemon at bugzilla.ximian.com bugzilla-daemon at bugzilla.ximian.com
Thu Jan 11 02:41:46 EST 2007


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by monkey at jpobst.com.

http://bugzilla.ximian.com/show_bug.cgi?id=80495

--- shadow/80495	2007-01-10 22:11:20.000000000 -0500
+++ shadow/80495.tmp.18074	2007-01-11 02:41:46.000000000 -0500
@@ -1,14 +1,14 @@
 Bug#: 80495
 Product: Mono: Class Libraries
 Version: 1.2
 OS: All
 OS Details: 
-Status: NEW   
-Resolution: 
-Severity: 
+Status: RESOLVED   
+Resolution: FIXED
+Severity: Unknown
 Priority: Normal
 Component: Windows.Forms
 AssignedTo: toshok at ximian.com                            
 ReportedBy: georgegiolfan at yahoo.com               
 QAContact: mono-bugs at ximian.com
 TargetMilestone: ---
@@ -49,6 +49,15 @@
 Always (on SVN version).
 
 ------- Additional Comments From georgegiolfan at yahoo.com  2007-01-10 22:11 -------
 Created an attachment (id=18478)
 Proposed patch
 
+
+------- Additional Comments From monkey at jpobst.com  2007-01-11 02:41 -------
+The patch is the right place, but there is an infinitesimally small
+chance that the button could be in a form which is in another form
+(MDI).  Using TopLevelControl would set the outer-most form's
+DialogResult.  I made it use FindForm() instead, which will find the
+inner-most form and set it's DialogResult.  Fixed in r70833.
+
+Thanks for the report and for doing the legwork to find the problem!  :)


More information about the mono-bugs mailing list