[Mono-bugs] [Bug 80571][Nor] Changed - [PATCH] resgen support for /usesourcepath (2.0)

bugzilla-daemon at bugzilla.ximian.com bugzilla-daemon at bugzilla.ximian.com
Tue Feb 6 07:20:24 EST 2007


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by frederik.carlier at ugent.be.

http://bugzilla.ximian.com/show_bug.cgi?id=80571

--- shadow/80571	2007-02-05 15:48:45.000000000 -0500
+++ shadow/80571.tmp.20808	2007-02-06 07:20:24.000000000 -0500
@@ -31,6 +31,17 @@
 Created an attachment (id=18616)
 Fix
 
 
 ------- Additional Comments From frederik.carlier at ugent.be  2007-02-05 15:48 -------
 I tested this fix, it works for me.
+
+------- Additional Comments From frederik.carlier at ugent.be  2007-02-06 07:20 -------
+Gert,
+
+I think there is a problem with this patch. In line 234 you call 
+  parts [0] = Path.Combine (BasePath, parts [0]);
+however, this doesn't deal with relative paths correctly (if escaped
+to the parent directory)
+You should add an extra line, like this:
+  parts [0] = Path.GetFullPath (parts [0]);
+But, this is currently broken on Mono. See bug 80737 for more on that.


More information about the mono-bugs mailing list