[Mono-bugs] [Bug 82531][Nor] Changed - CommonDialog only useful for Mono internal implementations

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by monkey at jpobst.com.

http://bugzilla.ximian.com/show_bug.cgi?id=82531

--- shadow/82531	2007-08-23 17:03:43.000000000 -0400
+++ shadow/82531.tmp.6586	2007-08-23 17:04:04.000000000 -0400
@@ -1,13 +1,13 @@
 Bug#: 82531
 Product: Mono: Class Libraries
 Version: 1.2
 OS: unknown
 OS Details: 
-Status: NEW   
-Resolution: 
+Status: RESOLVED   
+Resolution: FIXED
 Severity: Unknown
 Priority: Normal
 Component: Windows.Forms
 AssignedTo: monkey at jpobst.com                            
 ReportedBy: andyhume32 at yahoo.co.uk               
 QAContact: mono-bugs at ximian.com
@@ -89,6 +89,22 @@
 CommonDialog seems designed for ShowDialog to only return OK or 
 Cancel.  It guess it makes /some/ sense as those are the two buttons 
 in the file-open-like dialogs.  Why they didn't have RunDialog 
 return DialogResult too and then any result code could be returned I 
 don't know.
 
+
+------- Additional Comments From monkey at jpobst.com  2007-08-23 17:04 -------
+Fixed in r84749.  Thanks for the report!
+
+2007-08-23  Jonathan Pobst  <monkey at jpobst.com>
+
+	* CommonDialog.cs: Do not instantiate form, leave that for derived
+classes.
+	This way we can tell if this is a CommonDialog provided with mono, or one
+	that is being implemented outside by a developer.  If it is an
+external one,
+	the developer is responsible for showing their own form.  We were showing
+	our blank form after the developer showed his.
+	* ColorDialog.cs, FileDialog.cs, FolderBrowserDialog.cs, FontDialog.cs,
+	PageSetupDialog.cs: Instantiate form variable in our constructor.
+	[Fixes bug #82531]