[Mono-bugs] [Bug 82400][Nor] Changed - [PATCH] DateTime binary serialization incompatible with MS.NET 2.0

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by robertj at gmx.net.

http://bugzilla.ximian.com/show_bug.cgi?id=82400

--- shadow/82400	2007-08-21 15:22:26.000000000 -0400
+++ shadow/82400.tmp.14676	2007-08-22 06:54:02.000000000 -0400
@@ -207,6 +207,29 @@
 
 ------- Additional Comments From jaebird at gmail.com  2007-08-21 15:22 -------
 This patch uses the ToBinary/FromBinary which is better. Thanks to
 Robert for pointing that out. It replaces patch from 08/21/07 14:20
 
 Cheers,
+
+------- Additional Comments From robertj at gmx.net  2007-08-22 06:54 -------
+> Also for the record:
+> I would not say that this fixes binary serialization. If you do a
+> binary serialization with BinaryFormatter of DateTime (ie to a file)
+> it must do it the way Lionel's patch does it in the custom formatter.
+
+This statement raised my curiosity, because "it cannot be" ;-)
+
+The problem why it looks like when Lionel's patch were necessary, is
+the fancy implementation of the binary formatter: it dynamically
+generates code that serializes classes optimally fast.
+
+This code path is not entered for remoting method messages,
+because it would rather harm than help (too much overhead).
+
+To be complete (and also to fix serialization of classes containing
+DateTime fields), 
+
+class/corlib/System.Runtime.Serialization.Formatters.Binary/CodeGenerator.cs
+
+must be adjusted as well.
+