[Mono-bugs] [Bug 82462][Min] Changed - Enumerable.Aggregate behaves incorrectly
bugzilla-daemon at bugzilla.ximian.com
bugzilla-daemon at bugzilla.ximian.com
Thu Aug 16 19:22:24 EDT 2007
Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.
Changed by m.j.hutchinson at gmail.com.
http://bugzilla.ximian.com/show_bug.cgi?id=82462
--- shadow/82462 2007-08-16 19:21:32.000000000 -0400
+++ shadow/82462.tmp.32332 2007-08-16 19:22:24.000000000 -0400
@@ -1,14 +1,14 @@
Bug#: 82462
Product: Mono: Class Libraries
Version: unspecified
-OS:
+OS: unknown
OS Details:
Status: NEW
Resolution:
-Severity:
+Severity: Unknown
Priority: Minor
Component: Sys.Core
AssignedTo: mono-bugs at ximian.com
ReportedBy: m.j.hutchinson at gmail.com
QAContact: mono-bugs at ximian.com
TargetMilestone: ---
@@ -20,6 +20,17 @@
(it's obvious in the code).
------- Additional Comments From m.j.hutchinson at gmail.com 2007-08-16 19:21 -------
Created an attachment (id=19825)
A patch for the issue.
+
+------- Additional Comments From m.j.hutchinson at gmail.com 2007-08-16 19:22 -------
+Here's a patch. Should I commit?
+
+I've rewritten the method more efficiently by manually writing the
+"foreach", to avoid having an "if" within the loop. This does not IMO
+make the code any less readable, and actually makes it shorter.
+
+I've used 4-spaces for indentation rather than tabs, to conform with
+the existing code (which consistently violates the Mono Coding
+Guidelines in several ways!).
More information about the mono-bugs
mailing list