[Mono-bugs] [Bug 82187][Nor] Changed - SaveFileDialog empty and no longer in center of screen when displayed multiple times

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by contact at i-nz.net.

http://bugzilla.ximian.com/show_bug.cgi?id=82187

--- shadow/82187	2007-07-31 07:35:36.000000000 -0400
+++ shadow/82187.tmp.17482	2007-08-16 06:45:45.000000000 -0400
@@ -1,13 +1,13 @@
 Bug#: 82187
 Product: Mono: Class Libraries
 Version: 1.2
 OS: All
 OS Details: 
-Status: RESOLVED   
-Resolution: FIXED
+Status: REOPENED   
+Resolution: 
 Severity: Unknown
 Priority: Normal
 Component: Windows.Forms
 AssignedTo: rolfkvinge at ya.com                            
 ReportedBy: gert.driesen at pandora.be               
 QAContact: mono-bugs at ximian.com
@@ -50,6 +50,32 @@
 
 ------- Additional Comments From rolfkvinge at ya.com  2007-07-31 07:35 -------
 Fixed in r83065.
 
 Now I don't know if this fix should be backported or not (it did 
 cause a few tests to fail at first).
+
+------- Additional Comments From contact at i-nz.net  2007-08-16 06:45 -------
+A part of the fix for this bug causes a regression which causes
+incorrect drawing and maxed out CPU. Attached a binary reproducer. Run
+it -> File -> Open -> Form1.cs. The hunk from the patch that causes
+the regression is pasted below.
+
+
+Modified:
+trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/Control.cs
+===================================================================
+---
+trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/Control.cs
+      2007-07-31 09:12:37 UTC (rev 83064)
++++
+trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/Control.cs
+      2007-07-31 10:55:20 UTC (rev 83065)
+@@ -5115,6 +5115,7 @@
+ #endif
+                        window.InvalidateHandle();
+
++                       is_created = false;
+                        if (is_recreating) {
+ #if DebugRecreate
+                                Console.WriteLine ("Creating handle
+for {0:X}", handle.ToInt32());