[Mono-bugs] [Bug 79385][Nor] Changed - [PATCH] Generic List serialization not compatible with MS

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by gert.driesen at pandora.be.

http://bugzilla.ximian.com/show_bug.cgi?id=79385

--- shadow/79385	2006-09-15 14:42:15.000000000 -0400
+++ shadow/79385.tmp.10710	2006-09-15 14:56:01.000000000 -0400
@@ -1,14 +1,14 @@
 Bug#: 79385
 Product: Mono: Class Libraries
 Version: 1.1
-OS: 
+OS: unknown
 OS Details: 
 Status: NEW   
 Resolution: 
-Severity: 
+Severity: Unknown
 Priority: Normal
 Component: CORLIB
 AssignedTo: mono-bugs at ximian.com                            
 ReportedBy: gert.driesen at pandora.be               
 QAContact: mono-bugs at ximian.com
 TargetMilestone: ---
@@ -36,6 +36,24 @@
 
 
 ------- Additional Comments From gert.driesen at pandora.be  2006-09-15 14:42 -------
 Created an attachment (id=17693)
 Fixes and unit tests
 
+
+------- Additional Comments From gert.driesen at pandora.be  2006-09-15 14:56 -------
+I discovered why our binary serialization did not match that of MS: 
+the _version field in List<T> was never getting incremented.
+
+I found this very strange, since there the version checks are 
+implemented in List<T>.Enumerator, but that does not have any effect 
+if the _version field is never touched.
+
+After my changes, our binary serialization matches that of MS and 
+the version checks in List<T>Enumerator match that of MS.
+
+Both changes are covered by unit tests.
+
+Let me know if its ok to commit these changes (or if you want me to 
+create a separate bug report for the version check issue).
+
+