[Mono-bugs] [Bug 79173][Nor] Changed - Label: multiple newlines in text are ignored

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by sebastien at ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=79173

--- shadow/79173	2006-09-13 11:31:30.000000000 -0400
+++ shadow/79173.tmp.5515	2006-09-13 11:49:26.000000000 -0400
@@ -1,22 +1,21 @@
 Bug#: 79173
 Product: Mono: Class Libraries
 Version: 1.1
 OS: unknown
 OS Details: 
-Status: NEW   
+Status: NEEDINFO   
 Resolution: 
 Severity: Unknown
 Priority: Normal
 Component: Sys.Drawing.
 AssignedTo: mono-bugs at ximian.com                            
 ReportedBy: gert.driesen at pandora.be               
 QAContact: mono-bugs at ximian.com
 TargetMilestone: ---
 URL: 
-Cc: 
 Summary: Label: multiple newlines in text are ignored
 
 The Label control ignores multiple newlines in the text.
 
 To reproduce, compile and run the attached source code.
 
@@ -92,6 +91,37 @@
 attachment). In fact I don't see how the new lines gets processed ?!?
 
 CurrentDetail->Linefeeds tracks the '\n' inside the string, however
 that value isn't used anywhere else (except in DRAWSTRING_DEBUG
 blocks). So there's (probably) something else I'm missing (and the
 Linefeeds variable is unused) or it just can't work.
+
+------- Additional Comments From sebastien at ximian.com  2006-09-13 11:49 -------
+This was broken in r62329
+(http://svn.myrealbox.com/viewcvs/trunk/libgdiplus/src/graphics.c?rev=62329&r1=61133&r2=62329)
+where the multiplication of the LineHeight with
+CurrentDetail->Linefeeds was removed. Not quite sure why from the
+ChangeLog.
+
+Index: graphics.c
+===================================================================
+--- graphics.c  (revision 65349)
++++ graphics.c  (working copy)
+@@ -2400,7 +2400,7 @@
+                }
+                if (CurrentDetail->Flags & STRING_DETAIL_LF) {
+                        CursorX = 0;
+-                       CursorY += LineHeight;
++                       CursorY += LineHeight * CurrentDetail->Linefeeds;
+                        CurrentDetail->Flags |= STRING_DETAIL_LINESTART;
+                        CurrentLineStart = CurrentDetail;
+ #ifdef DRAWSTRING_DEBUG
+@@ -3200,7 +3200,7 @@
+                }
+                if (CurrentDetail->Flags & STRING_DETAIL_LF) {
+                        CursorX=0;
+-                       CursorY+=LineHeight;
++                       CursorY+=LineHeight * CurrentDetail->Linefeeds;
+                        CurrentDetail->Flags|=STRING_DETAIL_LINESTART;
+                        CurrentLineStart=CurrentDetail;
+ #ifdef DRAWSTRING_DEBUG
+