[Mono-bugs] [Bug 79629][Nor] Changed - [PATCH] Form does not redraw correctly when MaximizeBox or MinimizeBox is false and a control's visibility is changed

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by rolfkvinge at ya.com.

http://bugzilla.ximian.com/show_bug.cgi?id=79629

--- shadow/79629	2006-10-22 16:55:44.000000000 -0400
+++ shadow/79629.tmp.1908	2006-10-25 13:43:26.000000000 -0400
@@ -120,6 +120,28 @@
 
 
 ------- Additional Comments From toshok at ximian.com  2006-10-22 16:55 -------
 could you guys check with the current svn?  i backed out all the
 children_to_recreate stuff, since it was hopelessly broken and
 completely unnecessary.
+
+------- Additional Comments From rolfkvinge at ya.com  2006-10-25 13:43 -------
+My last test case still fails, the problem is that the combo's 
+internal textbox is added to the combo's controls using AddImplicit, 
+and implicit child controls are not recreated. The following patch 
+fixes this. 
+Btw SetIsRecreating takes a flag that's never used (is_recreating is 
+always set to true).
+
+Index: System.Windows.Forms/Control.cs
+===================================================================
+--- System.Windows.Forms/Control.cs	(revision 66954)
++++ System.Windows.Forms/Control.cs	(working copy)
+@@ -3557,7 +3557,7 @@
+ 		{
+ 			is_recreating=true;
+ 
+-			foreach (Control c in Controls) {
++			foreach (Control c in Controls.GetAllControls()) {
+ 				c.SetIsRecreating (flag);
+ 			}
+ 		}