[Mono-bugs] [Bug 77792][Nor] Changed - Poor performace of Int32.ToString () and other primitive types

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by atsushi at ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=77792

--- shadow/77792	2006-03-15 18:33:07.000000000 -0500
+++ shadow/77792.tmp.30339	2006-03-16 02:04:57.000000000 -0500
@@ -102,6 +102,21 @@
 
 ------- Additional Comments From bmaurer at users.sf.net  2006-03-15 18:33 -------
 Yeah, most of the perf issues here came from kazuki's refactoring.
 I've often noticed that code which calls int.tostring is doing so too
 frequently, and that a good solution often involves removing such
 calls. With that said, we should still try to optimize the fast paths.
+
+------- Additional Comments From atsushi at ximian.com  2006-03-16 02:04 -------
+Yeah, that NumberFormatter change fixed many bugs and brought
+performance down as it had been known. I remember that I was most
+cautious among who argued whether checkin the patch or not.
+
+Now that the code has been unchanged about a year it would make sense
+to start optimization changes. But there is a new related formatting
+bug (as noted above), so I think it should be done after the bug fix.
+(I am pretty much aware about perf. issue thus I rather refrained from
+applying that "just works" patch provided for that bug.)
+
+(For .NET 2.0 enhancements I believe there are almost no changes in
+int.ToString() itself behind such "small" 9.0/7.0 performance
+improvement.)