[Mono-bugs] [Bug 77268][Wis] Changed - Sqlite DateTime Parameters Handled Incorrectly

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by anmar at gmx.net.

http://bugzilla.ximian.com/show_bug.cgi?id=77268

--- shadow/77268	2006-07-19 14:58:06.000000000 -0400
+++ shadow/77268.tmp.13331	2006-07-19 15:09:44.000000000 -0400
@@ -1,13 +1,13 @@
 Bug#: 77268
 Product: Mono: Class Libraries
 Version: 1.1
 OS: All
 OS Details: 
-Status: RESOLVED   
-Resolution: NOTABUG
+Status: REOPENED   
+Resolution: 
 Severity: Unknown
 Priority: Wishlist
 Component: Sys.Data.SqlClient
 AssignedTo: tsenganal at novell.com                            
 ReportedBy: jhill at arcfocus.com               
 QAContact: mono-bugs at ximian.com
@@ -229,6 +229,32 @@
 open a new one for this?
 
 ------- Additional Comments From anmar at gmx.net  2006-07-19 14:58 -------
 Created an attachment (id=17322)
 Add support for multiple date storage modes
 
+
+------- Additional Comments From anmar at gmx.net  2006-07-19 15:09 -------
+The attached patch adds a date_storage connection string parameter to
+select how DateTime should be stored in sqlite.
+
+- date_storage=0 Is the default and maintains the current
+implementation using ToFileTime() and FromFileTime()
+
+- date_storage=1 stores dates as 'the number of days since noon in
+Greenwich on November 24, 4714 B.C' which is known as julian day
+number in sqlite land. Date functions in sqlite accept this number
+without extra work. It's also fast as is just a simple math operation.
+
+- date_storage=2 stores dates as a string that conforms to the
+ISO-8601 standard and are supported by SQLite 3.2.0 and later.
+
+- date_storage=3 stores dates as a string with 'yyyy-MM-dd HH:mm:ss'
+format, it's just for compatibility with older versions of sqlite that
+do not support ISO 8601 format.
+
+The date_storage values are numeric to avoid any extra string
+operations while setting or evaluating it's value so it does not
+impact performance.
+
+The patch also adds support to reverse the julian day number into a
+DateTime in SqliteDataReader.