[Mono-bugs] [Bug 78739][Nor] Changed - leaking tls data

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by vargaz at gmail.com.

http://bugzilla.ximian.com/show_bug.cgi?id=78739

--- shadow/78739	2006-06-30 12:13:11.000000000 -0400
+++ shadow/78739.tmp.10535	2006-07-08 13:24:34.000000000 -0400
@@ -357,6 +357,24 @@
 It would be _very_ useful to add some kind of io_layer_init () /
 io_layer_shutdown () calls which could be called from mono using
 #ifndef PLATFORM_WIN32. That would take care of all the shutdown leaks
 and having a definite init () function could possibly simplify some
 code as well.
 
+
+------- Additional Comments From vargaz at gmail.com  2006-07-08 13:24 -------
+I checked in most of the patch. The non-checked in parts are:
+- the io-layer changes, Dick should decide what to do with them
+- the introduction of mono_thread_pool_global_cleanup (). Why can't
+  those cleanup actions go to mono_thread_pool_cleanup () ?
+- this change:
+@@ -843,6 +844,7 @@
+                        /* MS seems to wait for about 2 seconds */
+                        if (WaitForSingleObjectEx (shutdown_event,
+2000, FALSE) == WAIT_TIMEOUT) {
+                                mono_thread_stop (gc_thread);
++                               mono_thread_detach(gc_thread);
+
+why is this needed ?
+- the call to mono_thread_pool_cleanup () in mini.c. That is already
+called from mono_thread_managed () in threads.c.
+