[Mono-bugs] [Bug 77256][Wis] Changed - [Patch] Fixes for failing LabelEventTests

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by peter at novonyx.com.

http://bugzilla.ximian.com/show_bug.cgi?id=77256

--- shadow/77256	2006-01-14 09:44:13.000000000 -0500
+++ shadow/77256.tmp.27678	2006-01-19 03:06:05.000000000 -0500
@@ -1,14 +1,14 @@
 Bug#: 77256
 Product: Mono: Class Libraries
 Version: 1.1
 OS: other
 OS Details: SUSE 10 OSS
-Status: NEW   
-Resolution: 
-Severity: 
+Status: RESOLVED   
+Resolution: FIXED
+Severity: Unknown
 Priority: Wishlist
 Component: Windows.Forms
 AssignedTo: peter at novonyx.com                            
 ReportedBy: dbjobs at snafu.de               
 QAContact: mono-bugs at ximian.com
 TargetMilestone: ---
@@ -40,6 +40,32 @@
 
 
 ------- Additional Comments From dbjobs at snafu.de  2006-01-14 09:44 -------
 Created an attachment (id=16341)
 Diff for LabelTest.cs + ChangeLog
 
+
+------- Additional Comments From peter at novonyx.com  2006-01-19 03:06 -------
+We cannot remove events and properties that are happen to also exist 
+in base, even if we just call the base methods. The reason is that we 
+must exactly match the Microsoft defined events and properties. In 
+the case of Label, Microsoft defines these events and properties new 
+and sets different attributes for them. These attributes allow the 
+properties and events to be hidden if you use a GUI-Designer (like 
+Visual Studio). It is not possible to change attributes for inherited 
+methods, so they need to define them anew. As for the overriden 
+methods, MS might be doing something in them for the specific class 
+were we don't need to because we have a different implementation, but 
+still, for binary compatibility we need to match the API.
+
+The change you made to LabelTest to make the test not fail is not 
+correct, too. While your patch will make the test pass, the test as 
+it is shows that our Label.TabStop is not defaulting to the right 
+value (we default to true, thus, when it's set to true the changed 
+event is not fired). MS defaults TabStop to false for Label, 
+therefore, when setting to true it will fire the event. The bug was 
+in Label, not in the test.
+
+I fixed Label to properly pass those tests now, I did take your 
+improvement using EventArgs.Empty instead of new EventArgs().
+
+Thanks for the bug report.