[Mono-bugs] [Bug 77602][Wis] Changed - fail to save assembly or create reflection assembly with system librairies

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by sebastien at ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=77602

--- shadow/77602	2006-02-20 15:26:49.000000000 -0500
+++ shadow/77602.tmp.25694	2006-02-20 15:54:06.000000000 -0500
@@ -1,12 +1,12 @@
 Bug#: 77602
 Product: Mono: Class Libraries
 Version: 1.1
-OS: GNU/Linux [Other]
+OS: unknown
 OS Details: 
-Status: NEEDINFO   
+Status: CLOSED   
 Resolution: 
 Severity: Unknown
 Priority: Wishlist
 Component: Mono.Cecil
 AssignedTo: mono at evain.net                            
 ReportedBy: guillaume.bour at free.fr               
@@ -132,6 +132,27 @@
 
 It happens in SignatureWriter.cs, line 445.
 Sometimes (I don't known why), elem.Value is Null.
 I quickly fixed it with a "if(s == null) { s = ""; }", then i had the
 second problem detailed in this bug report
 
+
+------- Additional Comments From sebastien at ximian.com  2006-02-20 15:54 -------
+Fixed in SVN (r57082).
+
+For the record I applied this patch to Cecil to replicate the issue.
+You should open another bug report about this.
+
+Index: Mono.Cecil.Signatures/SignatureWriter.cs
+===================================================================
+--- Mono.Cecil.Signatures/SignatureWriter.cs    (revision 57077)
++++ Mono.Cecil.Signatures/SignatureWriter.cs    (working copy)
+@@ -442,6 +442,7 @@
+                        case ElementType.String :
+                        case ElementType.Type :
+                                string s = (string) elem.Value;
++                               if (s == null) s = String.Empty;
+                                byte [] data = Encoding.UTF8.GetBytes (s);
+                                Utilities.WriteCompressedInteger
+(writer, data.Length);
+                                writer.Write (data);
+