[Mono-bugs] [Bug 77512][Nor] Changed - [PATCH] XmlSerializationWriter.WriteTypedPrimitive fixes

bugzilla-daemon at bugzilla.ximian.com bugzilla-daemon at bugzilla.ximian.com
Thu Feb 16 07:50:10 EST 2006

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by lluis at ximian.com.


--- shadow/77512	2006-02-09 13:38:26.000000000 -0500
+++ shadow/77512.tmp.5043	2006-02-16 07:50:10.000000000 -0500
@@ -54,6 +54,29 @@
 ------- Additional Comments From gert.driesen at pandora.be  2006-02-09 13:38 -------
 Created an attachment (id=16466)
 The real patch (previous one was for other bug)
+------- Additional Comments From lluis at ximian.com  2006-02-16 07:50 -------
+Gert, I really appreciate your work, but I'm not going to accept this
+patch unless I have a test cases based on XmlSerializer. The provided
+test cases only ensure that XmlSerializationWriter works like in
+MS.NET, which is good, but it is more important to ensure that those
+changes don't cause regressions in XmlSerializer, which might rely on
+our particular behavior.
+I'm specially afraid of changes like:
+- serializing an enum constant as xsi type fails with 
+since our serializer might still rely on the old behavior to work
+(this is just an example of my concerns, I haven't checked).
+You have to understand that we must be very careful with the changes
+we do, and be sure that they fix real bugs from the point of view of
+the serializer, which is what will be actually used by applications.

More information about the mono-bugs mailing list