[Mono-bugs] [Bug 77392][Nor] Changed - [PATCH] XmlReflectionImporter / SoapReflectionImporter fixes

[bugzilla-daemon at bugzilla.ximian.com]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by lluis at ximian.com.

http://bugzilla.ximian.com/show_bug.cgi?id=77392

--- shadow/77392	2006-02-08 14:25:50.000000000 -0500
+++ shadow/77392.tmp.16551	2006-02-08 14:41:46.000000000 -0500
@@ -112,6 +112,27 @@
 +			XmlTypeMapping map = helper.GetRegisteredClrType (type, ns);
 
 you are ignoring the defaultNamespace parameter with this change. I
 feel that's not correct.
 
 
+
+------- Additional Comments From lluis at ximian.com  2006-02-08 14:41 -------
+About the unit tests: checking the properties of XmlTypeMapping is ok,
+but this kind of test won't help in making sure that serialization works.
+
+For example, see this change in XmlReflectionImporter.cs:170:
+
+-			if (rootNamespace == null) rootNamespace = "";
++			if (typeData.SchemaType == SchemaTypes.XmlNode)
++				rootNamespace = null;
++			else if (rootNamespace == null) 
++				rootNamespace = "";
+
+What I'd like to have is a test for the effect of this change in the
+output of the serializer. If it doesn't have any effect, maybe the
+change is not worth it. After all, nobody uses XmlTypeMapping
+directly. Moreover, the serializer could be relying on the old value
+to produce the correct output, so we might be introducing a regression
+here.
+
+