[Mono-bugs] [Bug 77500][Nor] Changed - [PATCH] XmlCustomFormatter / XmlSerializationWriter fixes

bugzilla-daemon at bugzilla.ximian.com bugzilla-daemon at bugzilla.ximian.com
Wed Feb 8 13:04:17 EST 2006

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by lluis at ximian.com.


--- shadow/77500	2006-02-08 04:08:53.000000000 -0500
+++ shadow/77500.tmp.15335	2006-02-08 13:04:17.000000000 -0500
@@ -93,6 +93,16 @@
 not make sense ofcourse) and you pass value 8, then it makes more 
 sense to say that '8' is an invalid value instead of '4', no ?
 About mixing test addition and replacing Assertion->Assert: you're 
 right, I should've split this up. But then again, I can hardly 
 submit a bug report for Assertion -> Assert ;-)
+------- Additional Comments From lluis at ximian.com  2006-02-08 13:04 -------
+The patch looks good to me, feel free to commit.
+However, the FromEnum and ToEnum methods are not used anywhere in the
+serializer. This makes me wonder if we are missing something. Maybe we
+should test all this by doing a real serialization of a class with
+enum values.
+Thanks anyway for the patch!

More information about the mono-bugs mailing list